This repository was archived by the owner on Aug 21, 2025. It is now read-only.
Conversation
There was a problem hiding this comment.
Pull Request Overview
This pull request increases the API key expiry time to one year and bumps various dependency versions used by Trunk.
- Increase API key expiry value in the login command from 7 days to 365 days.
- Upgrade versions of several CLI and linter tools in the trunk configuration.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/commands/login/index.ts | Updated the API key expiration time handling in the request. |
| .trunk/trunk.yaml | Bumped versions for the CLI and linter tools. |
Comments suppressed due to low confidence (2)
src/commands/login/index.ts:106
- No tests were added for the increased API key expiry time. Please add appropriate tests to verify that the new expiration behavior works as expected.
expiresIn: 60 * 60 * 24 * 365, // 365 days
.trunk/trunk.yaml:5
- Ensure that the CLI version bump does not introduce breaking changes in your local development environment. Confirm compatibility with any associated tooling or configurations.
version: 1.22.11
octref
approved these changes
Apr 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Increase api key expiry time to a year
Checklist